fix(race): support array of observables other than rest param #2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this is patch as it won't breaking existing behavior? (...while I'm currently bad at picking right version for changes though) |
|
uh..one another thing - const o1 = Observable.of(1);
const b = Observable.race(o1, o1); //b is inferred to Observable<any> instead of Observable<number>? |
benlesh
requested changes
Apr 12, 2017
|
Updated commit message. |
benlesh
approved these changes
Apr 13, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I just noticed
Observable.race([o1, o2])is not working cause current definition is shaped for rest param args only (soObservable.race(...[o1, o2])works. This PR aligns type definition to support those forms to actual operator behavior.Related issue (if exists):